search

gotwarlost / istanbul-middleware

Connect middleware for server side code coverage using istanbul
Other
178 stars 96 forks source link

istanbul-middleware.getInstrumentor() no longer works #15

Open mrvicadai opened 10 years ago

mrvicadai commented 10 years ago

this method is not exposed in handler.js

gotwarlost commented 10 years ago

https://github.com/gotwarlost/istanbul-middleware/blob/master/lib/core.js#L236

Maybe a typo on your part (ter not tor)?

mrvicadai commented 10 years ago

ohhh sorry about the typo. I mean the real issue is here: at index.js: module.exports = require('./lib/handlers'); so the handlers is exposed, however, in handlers.js: module.exports = { createClientHandler: createClientHandler, createHandler: createHandler, hookLoader: core.hookLoader }; looks like getInstrumenter() is not exposed.

ORESoftware commented 7 years ago

this seems legit... see => https://github.com/gotwarlost/istanbul-middleware/issues/47