search

gotwarlost / istanbul-middleware

Connect middleware for server side code coverage using istanbul
Other
179 stars 96 forks source link

Increased the accepted max file size, replaced obsolete call #6

Closed joelmertanen closed 10 years ago

joelmertanen commented 10 years ago

Middleware did not accept larger coverage json files than 1mb, which was not enough for us.

I did not find any reason for not increasing it. I set the limit to 100mb and also replaced the soon-to-be obsolete call bodyParser() with the json() and urlencoded().

gotwarlost commented 10 years ago

Thanks for the PR. Out of curiosity, could you tell me how you are using this library and for what purpose?

joelmertanen commented 10 years ago

Sweet, the lib is used to pass the coverage data from an istanbul instrumented code at the end of the Mocha tests, which are run via Grunt. Our coverage data is around 6mb:s, which caused the error. The current setup is a bit shaky, but it is more of a proof of concept.

gotwarlost commented 10 years ago

Added as part of PR #11. Available in v0.2.0