gotwarlost / istanbul

Yet another JS code coverage tool that computes statement, line, function and branch coverage with module loader hooks to transparently add coverage when running tests. Supports all JS coverage use cases including unit tests, server side functional tests and browser tests. Built for scale.

Other

8.7k stars 786 forks source link

swap fileset for glob, Fixes #638 #673

Closed popomore closed 8 years ago

popomore commented 8 years ago

I fixed the testcase picking from #648 and delete glob from devDependencies.

It can be closed once #648 have been merged.

coveralls commented 8 years ago

Coverage remained the same at 97.523% when pulling 92f458b41f33076b20d5cd820d6ee4f2ba6ba58c on popomore:swap-fileset-for-glob into fef889b14850bb35598599cb5b1954fd06d9993f on gotwarlost:master.

popomore commented 8 years ago

638

popomore commented 8 years ago

@mklabs @gotwarlost any suggestion?

popomore commented 8 years ago

ping @mklabs @gotwarlost

mklabs commented 8 years ago

Hi @popomore I really don't know what to do or to say. I personally think this is a good move and a really good PR. :+1:

popomore commented 8 years ago

now istanbul will break synk causing minimatch

popomore commented 8 years ago

ping @gotwarlost

popomore commented 8 years ago

@gotwarlost do you recommend to use nyc instead of istanbul?

popomore commented 8 years ago

ping @gotwarlost

maxkoryukov commented 8 years ago

I have tried to attach all related issues and pull requests

maxkoryukov commented 8 years ago

@gotwarlost, it is really useful PR, could you merge it? This PR solves all problems with fileset and there are no failures (mentioned here)

Also:

closes #648 (ORIGINAL PR with similar purpose)
closes #658 (PR with similar purpose)
fix #638
fix #678
fix #653

@popomore , if you will mention this list of issues in one of your commits' messages, then them all will become closed on merging

popomore commented 8 years ago

Thx @maxkoryukov, I have pushed with message body.

popomore commented 8 years ago

ping @gotwarlost

coveralls commented 8 years ago

Coverage remained the same at 97.523% when pulling 58f4c903b92dc09ff42a85c1257fe2e8ea2e7080 on popomore:swap-fileset-for-glob into fef889b14850bb35598599cb5b1954fd06d9993f on gotwarlost:master.

maxkoryukov commented 8 years ago

waiting for @gotwarlost

gotwarlost commented 8 years ago

Thanks for the PR. Sorry for the delay in merging this. Have been busy with other things...

gotwarlost commented 8 years ago

available in v0.4.5

maxkoryukov commented 8 years ago

Wooohooo)) You did it! Thanks!

maxkoryukov commented 8 years ago

@popomore , @graingert thank you, for the fix;)