Improve accessibility: change px to em

gotwarlost / istanbul

Yet another JS code coverage tool that computes statement, line, function and branch coverage with module loader hooks to transparently add coverage when running tests. Supports all JS coverage use cases including unit tests, server side functional tests and browser tests. Built for scale.

Other

8.7k stars 787 forks source link

Improve accessibility: change px to em #790

Open kidty85 opened 7 years ago

kidty85 commented 7 years ago

Dear @gotwarlost ,

I converted the px into the base.css file in em in order to improve accessibility. Please consider to accept my PR.

Regards

coveralls commented 7 years ago

Coverage remained the same at 97.523% when pulling cb59fc62d3f9af35a835a95123abf51878fcdb36 on kidty85:fix-fontsize-px-to-em into 89e338fcb1c8a7dea3b9e8f851aa55de2bc3abee on gotwarlost:master.

madarche commented 7 years ago

Any reason not to merge this PR?

The rationale is in "Using em units for font sizes" from https://www.w3.org/TR/WCAG20-TECHS/C14.html