search

gotwarlost / istanbul

Yet another JS code coverage tool that computes statement, line, function and branch coverage with module loader hooks to transparently add coverage when running tests. Supports all JS coverage use cases including unit tests, server side functional tests and browser tests. Built for scale.
Other
8.7k stars 786 forks source link

Fix "Cannot read property text of undefined" #816

Open glazar opened 7 years ago

glazar commented 7 years ago

Same code changes as found here https://github.com/istanbuljs-archived-repos/istanbul-reports/pull/10/commits/764cec03775dc3b7a812c6ff7782e011b8c85ca2

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 97.523% when pulling dec67e3186e67e94773ea590d7ad4ba33b2fc571 on glazar:structuredTextFix into bc84c315271a5dd4d39bcefc5925cfb61a3d174a on gotwarlost:master.

michaelBenin commented 7 years ago

My team could definitely use this PR. Thanks @glazar - hope it gets merged soon.

deibeljc commented 7 years ago

This is currently needed for us, is there any update on the status of this?

buenjybar commented 6 years ago

any status update on this ?

jacksonrayhamilton commented 6 years ago

@gotwarlost is this a sufficient and mergeable solution?

DonkeyKongJr commented 6 years ago

Figured out the same problem for us today. Any news on this?

po5i commented 6 years ago

This should be merged on master. Please @gotwarlost

MathRobin commented 6 years ago

Hi, any news about merge ?

Having the same problem targeted by the fix. Need to see it merged :s

(thanks for this wonderful tool)

po5i commented 6 years ago

I had to stick it to the commit at my package.json file. Let's wait until it's merged...

jacksonrayhamilton commented 6 years ago

R.I.P. @gotwarlost. If only he had willed this repository to a new maintainer…