gotwarlost / istanbul

Yet another JS code coverage tool that computes statement, line, function and branch coverage with module loader hooks to transparently add coverage when running tests. Supports all JS coverage use cases including unit tests, server side functional tests and browser tests. Built for scale.
Other
8.7k stars 786 forks source link

Updated handlebars to v4.4.5 to deal with multiple vulnerabilities #924

Open AaronNGray opened 4 years ago

AaronNGray commented 4 years ago

I have made a pull request just for an update to handlebars which causes multiple run time vulnerabilities in istanbul. I am wondering if we can just get this remedial update through.

I am trying to solve multiple vulnerabilities in karma packages karma-typescript and karma-coverage and this update to instanbul will solve all of these minus one.

Details :- https://github.com/karma-runner/karma/issues/2474#issuecomment-572173673

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 97.523% when pulling 7227665e8815981e1d24fe92d6d386554ad45a3f on AaronNGray:master into bc84c315271a5dd4d39bcefc5925cfb61a3d174a on gotwarlost:master.

AaronNGray commented 4 years ago

Please take this as a minor security update !