gotzl / ldparser

Parser for MoTec ld files
GNU General Public License v3.0
60 stars 14 forks source link

Use None instead of exception if an unknown channel dtype was read #16

Closed BeardedBeaver closed 1 year ago

BeardedBeaver commented 1 year ago

If an unknown channel dtype was read from ld file, currently reader raises an exception and no channel is returned. So it's impossible to update meta_ptr and the file becomes effectively unreadable. Instead I write None as dtype indicating that it's an unknown type and throw an exception in data, so the user can read all channels and deal with unknown formats later

gotzl commented 1 year ago

Sounds reasonable, thanks!