search

gouline / dbt-metabase

dbt + Metabase integration
https://pypi.org/project/dbt-metabase/
MIT License
442 stars 63 forks source link

feat: allow self reference #121

Closed joelluijmes closed 1 year ago

joelluijmes commented 1 year ago

New approach of #110. This logic now allows the self reference / circular reference.

I made this logic based on my initial work (i.e., before refactor of @gouline). By removing the set, it's now possible to have a self reference. In addition, as some assumptions are made I added some warning logger if in future dbt manifest changes.

Resolves #74

joelluijmes commented 1 year ago

Your PRs are still failing formatter check, run make check test before pushing.

I swear I ran black manually, but then didn't commit the changes... 🙈

When you say it allows self-referencing, does that mean it implements #74?

Yes this PR properly fixes #74. That is why I had to remove the set logic 🙂

gouline commented 1 year ago

Yes this PR properly fixes #74. That is why I had to remove the set logic 🙂

Excellent, adding a resolve hook to the description 🎉