search

gouline / dbt-metabase

dbt + Metabase integration
https://pypi.org/project/dbt-metabase/
MIT License
442 stars 63 forks source link

make dbt_includes and dbt_excludes case insensitive #123

Closed leoebfolsom closed 1 year ago

leoebfolsom commented 1 year ago

This PR addresses the issue I describe in #122 so that the user can enter a --dbt_includes argument with any casing (presumably lowercase will be most common) without conflicting with model_name, which is uppercase, in parsers/dbt_manifest.py.

Resolves #122

gouline commented 1 year ago

Run make check test locally before pushing to make sure checks and tests are passing.

leoebfolsom commented 1 year ago

@gouline I ran make check test and I believe everything passed, except for the following warning, which I don't think has to do with my code changes?

/dbt-metabase/tests/test_metabase.py:335: ResourceWarning: unclosed file <_io.TextIOWrapper name='tests/fixtures/lookups/table_lookups.json' mode='r' encoding='UTF-8'>
  baseline_table_lookups = json.load(
ResourceWarning: Enable tracemalloc to get the object allocation traceback
/dbt-metabase/tests/test_metabase.py:338: ResourceWarning: unclosed file <_io.TextIOWrapper name='tests/fixtures/lookups/field_lookups.json' mode='r' encoding='UTF-8'>
  baseline_field_lookups = json.load(
ResourceWarning: Enable tracemalloc to get the object allocation traceback