search

gouline / dbt-metabase

dbt + Metabase integration
https://pypi.org/project/dbt-metabase/
MIT License
442 stars 63 forks source link

fix: Consistent model selection in parsing #141

Closed gouline closed 1 year ago

gouline commented 1 year ago

Resolves #140

gouline commented 1 year ago

@willbryant See if this works for you before I merge and release

willbryant commented 1 year ago

@gouline Nope it's actually doing completely NOOP runs on this branch. No further output after the "Session established successfully" banner.

Rolled back to 0.9.7 and it's working again, so don't think it's something wrong with my configuration.

gouline commented 1 year ago

Drop any details of your configuration (e.g. which parser you use) that I would need to reproduce and I'll look into it when I have time.

gouline commented 1 year ago

Actually @willbryant give it another go, I fixed a silly typo that may have been causing the noop 🤔

willbryant commented 1 year ago

It's still skipping for me. -v shows:

DEBUG    Skipping DIM_CUSTOMERS in schema BI not in target schema PUBLIC                                                                                                                                                                                    dbt_manifest.py:65

Which is not what the previous version did. It starts working again if I add:

dbt_schema: bi

To my config. Whereas before, I just had:

  dbt_schema_excludes:
  - bi_dbt_ga4

IOW I think the behavior change is that now effectively only one schema at a time is supported?

gouline commented 1 year ago

That makes sense, I was testing with the folder parser. Latest commit should fix the issue you raised.

willbryant commented 1 year ago

Yup that's working - thanks.