search

gouline / dbt-metabase

dbt + Metabase integration
https://pypi.org/project/dbt-metabase/
MIT License
442 stars 63 forks source link

fix: skip incoming relationship tests #158

Closed CarolynMooney closed 1 year ago

CarolynMooney commented 1 year ago

The tool appears to read all relationship tests, both outgoing (the fk_target_table is a model not currently being read), as well as incoming (the fk_target_table is the model currently being read). If table A is the table currently being read by the tool, and it has a relationship test for a field referring to table B, then that field in table A should then have a foreign key (type/FK) pointing towards table B. Currently however it also looks the other way around to find foreign key fields in table B, pointing towards table A, but uses these to mark them as foreign key fields in table A (if the field names match between both tables).

This PR ignores those incoming relationship tests when detecting fields for foreign keys.

Fixes #157

gouline commented 1 year ago

Please address failed validation checks

gouline commented 1 year ago

Looks like your change breaks tests. Some inputs for parser tests may contain cases that fulfil your criterion, so you may have to update the expected outputs to match what your change attempts to achieve.

See readme on how to run tests locally while fixing them, GitHub only allows maintainer (me) to run them in Actions.

CarolynMooney commented 1 year ago

Thanks, we were just working on fixing those tests in the latest commit. They should pass now.

CarolynMooney commented 1 year ago

Thanks! Could this be released as a new version so that our team can use it?