search

gouline / dbt-metabase

dbt + Metabase integration
https://pypi.org/project/dbt-metabase/
MIT License
442 stars 63 forks source link

Remove unused statement in metabase.py #164

Closed moreaupascal56 closed 1 year ago

moreaupascal56 commented 1 year ago

Hey,

As discussed here #163 just a small cleaning by Pycharm. As sync_successful will always be changed line 232 sync_successful = self.models_compatible(models) because the first iteration of the loop will always be executed the assignment to False is unused.

gouline commented 1 year ago

Not a typo, it indicates the default state is. Helpful if the loop becomes dependent on a condition.

moreaupascal56 commented 1 year ago

Alright yes I was wondering if it was an hint maybe.