search

gouline / dbt-metabase

dbt + Metabase integration
https://pypi.org/project/dbt-metabase/
MIT License
442 stars 63 forks source link

Improvements #174

Closed elongl closed 10 months ago

elongl commented 10 months ago
  1. The first change also searches for dbt property files in models/*.yaml and not only models/*.yml.
  2. The second change corrects the format of exposures. 2.1 In dbt 1.3.0 onwards, you're not allowed to have upper-case characters in the exposure's name. 2.2 If a dashboard has two entities that query the same table, they'll be a duplicate in depends_on. I applied a dedup for that.
  3. Listing dbt tables (models, sources) using dbt ls. The main motivation for doing so is being able to safely get dbt models that are not defined in the property YAML files. An alternative would've been to parse models/*.sql files but that's difficult due to the alias config that can override the table name from the default file name. Using dbt ls allows us to safely get the table name.
gouline commented 10 months ago

Can you please split these into separate pull requests?

They're not related to each other, so if there are issues attributed to them down the line, we need to be able to roll back to specific changes.

elongl commented 10 months ago

For sure, definitely makes more sense. Closing.