search

gouline / dbt-metabase

dbt + Metabase integration
https://pypi.org/project/dbt-metabase/
MIT License
461 stars 71 forks source link

feat: allow custom headers to be sent through http requests #180

Closed tanguyantoine closed 12 months ago

tanguyantoine commented 12 months ago

What

Why

Use case

it allows instances to be reached when they are deployed behind security system (ex https://developers.cloudflare.com/cloudflare-one/identity/service-tokens/#connect-your-service-to-access)

example

dbt-metabase models --http_extra_headers CF-Access-Client-Id $CF_CLIENT_ID --http_extra_headers CF-Access-Client-Secret $CF_CLIENT_SECRET

thanks to @elongl and @elementary-data for the initial implementation

https://github.com/elementary-data/dbt-metabase/commit/91c34651ab323653c993820222670c27df19b38f

tanguyantoine commented 12 months ago

@gouline I have run black to format the files correctly

gouline commented 12 months ago

To save time, run all the checks locally prior to pushing commits.

tanguyantoine commented 12 months ago

@gouline sorry for that, I have run make check and it is working now :-)