gouline / dbt-metabase

dbt + Metabase integration
https://pypi.org/project/dbt-metabase/
MIT License
462 stars 71 forks source link

Argument naming, ordering and logic consistency #31

Closed gouline closed 3 years ago

gouline commented 3 years ago

Big refactor of CLI/programmatic entry point arguments, to achieve some readability and consistency.

We're making a lot of breaking changes with the next release that will feature manifest parsing, we may as well break anything else we need in the process to go along with it.

(Addresses #30 among other things)

gouline commented 3 years ago

FYI: @z3z1ma, @fernandobrito, @remigabillet, @erika-e

erika-e commented 3 years ago

Should the version number change, since these are breaking changes? Otherwise looks good to me!

gouline commented 3 years ago

Version changes are done outside of feature PRs. The next version will include quite a few changes.