search

gouline / dbt-metabase

dbt + Metabase integration
https://pypi.org/project/dbt-metabase/
MIT License
442 stars 63 forks source link

Outdated documentation #53

Closed fernandobrito closed 2 years ago

fernandobrito commented 2 years ago

An Issue to keep track of what should be updated in the docs before releasing 0.8.0:

Anything else you are aware? I can open a PR if needed. I just wanted to do many things in one-go 😄

gouline commented 2 years ago

Thanks for raising this, would definitely appreciate a PR for this 👍

z3z1ma commented 2 years ago

Hello! 👋

Correct me if I am wrong but aren't these in the docs?

image

fernandobrito commented 2 years ago

@z3z1ma yes, the docs are good. Just one command example that is missing the word export and in the other one, it is missing the word models.

gouline commented 2 years ago

I think that's a bug, export should have been replaced with models and exposures. Correct me if I'm wrong @z3z1ma?

This line should be removed https://github.com/gouline/dbt-metabase/blob/master/dbtmetabase/__init__.py#L196

z3z1ma commented 2 years ago

Ah yes that is exactly right. The commands should simply be models and exposures A future command is metrics

Makes it very easy to use. Good catch on that.