gouline / dbt-metabase

dbt + Metabase integration
https://pypi.org/project/dbt-metabase/
MIT License
462 stars 71 forks source link

Use metadata API endpoint for initial lookup tables #6

Closed gouline closed 4 years ago

gouline commented 4 years ago

Replace /tables and /fields API calls with one /metadata call for initial lookup tables.

Discussion: https://github.com/gouline/dbt-metabase/issues/4

gouline commented 4 years ago

@davideanastasia I got you started on this one. The lookup tables have been swapped over, just need to test whether posting the changes back still works.

It currently posts all the fields received from the get with the changes made, I'm considering changing that to posting only the fields that changed. Reason being, /metadata endpoint has more fields that might confuse it.

gouline commented 4 years ago

Fixed the field posting issue I mentioned above and tested. Have a look and see if that's what you had in mind.