search

gouline / dbt-metabase

dbt + Metabase integration
https://pypi.org/project/dbt-metabase/
MIT License
442 stars 63 forks source link

Doc update / default value needed: schema sync behavior #69

Closed mmmatthew closed 2 years ago

mmmatthew commented 2 years ago

The sync timeout should have a default value otherwise the behavior is not as described

Current behavior:

Sync is only attempted if metabase_sync_timeout is defined (default is None)

current docstring:

metabase_sync_timeout (Optional[int], optional): Synchronization timeout (in secs). If set, we will fail hard on synchronization failure; if not set, we will proceed after attempting sync regardless of success. Only valid if sync is enabled. Defaults to None.

https://github.com/gouline/dbt-metabase/blob/e7c7832c473b8d17ad2dd02f402c881e93897332/dbtmetabase/__init__.py#L546

z3z1ma commented 2 years ago

Commented directly on PR with thoughts.