search

gouline / dbt-metabase

dbt + Metabase integration
https://pypi.org/project/dbt-metabase/
MIT License
442 stars 63 forks source link

Feature/caveats and points of interest #76

Closed patygold closed 2 years ago

patygold commented 2 years ago

Problem

There are plus two fields on Metabase table's description, which can also be added to this automation. On Metabase they are called “Why this table is interesting“ and “Things to be aware of about this table“.

Approach

patygold commented 2 years ago

@gouline BTW, I've run the check-type locally, and the error seems not to be related to my changes specifically. Maybe you have more information on that? Specifically, the error I get is:


(agr-meltano) ➜  dbt-metabase git:(feature/caveats_and_points_of_interest) ✗ make check-fmt check-lint check-type
black --check .
All done! ✨ 🍰 ✨
18 files would be left unchanged.
pylint dbtmetabase

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

mypy dbtmetabase
dbtmetabase/__init__.py:7: error: Skipping analyzing "click": found module but no type hints or library stubs
dbtmetabase/__init__.py:7: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 1 error in 1 file (checked 14 source files)
make: *** [check-type] Error 1
gouline commented 2 years ago

@gouline BTW, I've run the check-type locally, and the error seems not to be related to my changes specifically. Maybe you have more information on that? Specifically, the error I get is:

GitHub Action ran successfully, so it must be your local setup. I'll try to review your changes this week (or @z3z1ma tag in, if you have time).

z3z1ma commented 2 years ago

:+1: I should have some time tomorrow to jump in and review.

patygold commented 2 years ago

@z3z1ma Any news with this review?

z3z1ma commented 2 years ago

Sorry @patygold @gouline Work has been nuts lately.

It all looks good to me, just one comment I on the possible "" string being passed into API which I believe is rejected. Could only happen by user error but I think we can be graceful and make sure a falsey string is just set to None to be safe