search

gouline / dbt-metabase

dbt + Metabase integration
https://pypi.org/project/dbt-metabase/
MIT License
442 stars 63 forks source link

fix: Handle 404s for deactivated users when exporting exposures #96

Closed kochalex closed 2 years ago

kochalex commented 2 years ago

This fixes an issue where exporting exposures crashes dbt-metabase when the owner of a card is a deactivated user. The metabase API has a check if a user is deactivated when running a GET to /api/user/:id and returns a 404.

Fixes: https://github.com/gouline/dbt-metabase/issues/88

kochalex commented 2 years ago

Updated the error handling - I'm also happy to add a new card to the mocked responses to test the 404 per your other comment if you would like.

z3z1ma commented 2 years ago

I'm good with this pending the additional test mock plus making CI pass.

gouline commented 2 years ago

@kochalex Still planning to get this merged?