Side effects of menu background color change

[GoogleCodeExporter]

Since r1940, the Options menu changes the 
background of the currently selected item. This was 
a necessary change since the previous solution 
(highlight the text of the currently selected item) 
couldn't handle lines which had icons instead of 
text (the icons couldn't get highlighted, so the 
currently selected line wasn't highlighted at all, 
and the user ha no way of knowing which item was 
currently selected).

This has side effects in other menus though:

- In the Trophy Room, the text "O: Collection 
Info" and "O: Card Spoiler", which appears in the 
upper left corner when the "Valuable Collection" 
achievement or any unlocked set are selected, also 
has the grey background. It looks a bit out of 
place there.

- On the "Add Filter" screen (accessible from the 
shop and from the deck editor), if you click on 
"Add filter" and then move the cursor down to the 
"Cards" item, an odd "double background" effect 
appears. The background of the filter gets a grey 
background, and then the background of the 
currently selected part of that filter gets another 
grey background. The background for the whole 
filter line is irritating here.

Also, some screens which would actually profit from 
having the grey background, don't get it. The grey 
background would be helpful in the shop's "card 
list" display (the contrast between selected and 
unselected items is very low there), also in some 
menus. Adding the background to more menus would 
also remove a potential problem with themes. (If a 
theme happens to use a font with a color that's 
very close to our color for highlighted items, then 
it'll be nigh impossible to spot the selected item.)

Original issue reported on code.google.com by Psyyri...@gmail.com on 28 Feb 2010 at 2:33

[GoogleCodeExporter]

I haven't had time this weekend for much Wagic, but it sounds like the problem 
your
describing has to do with whether or not a menu uses the WGui classes. I'll 
look into
a solution Monday for the double backgrounds, and hopefully next release I'll 
have
time to move more menus over to the new generic classes.

Original comment by wagic.jeck@gmail.com on 28 Feb 2010 at 2:50