search

goupviet / svg-edit

Automatically exported from code.google.com/p/svg-edit
0 stars 0 forks source link

No Text-anchor for text boxes in UI #514

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Click on the text button.
2. Click on the canvas.

What is the expected output? What do you see instead?
There should be a way to align the text either left, center, or right. 
There is no way to do this.  The SVG equivalent is text-anchor start,
middle, end. 

In what browser did you experience this problem? (ALL, Firefox, Opera 10
Alpha, etc)
Firefox & Chrome

Please provide any additional information below.
I created a way to do this by modifying three files:
svg-editor.html  (Added drop down menu for text align)
svg-editor.js (Added text-anchor change event)
svgcanvas.js (Added changeAttribute text-anchor)

Now I want to submit this.  But being new here, I did not want to face
backlash because I did not know the system.  Can I submit it using SVN?

Also, I do not know how to do a getAttribute of text and change the
drop-down list.

Original issue reported on code.google.com by anas.has...@gmail.com on 29 Mar 2010 at 12:55

Attachments:

GoogleCodeExporter commented 9 years ago 
Hi Anas,

Thanks and I will try to take a look at your changes.  Though I should warn you 
that
there were reasons for the current approach (specifically they had to do with
changing rotated text).  Will add further details to this bug.

It might be better to do a svn diff > mypatch.txt and just attach the single 
patch
text file (it is easier to apply and diff).  If you cannot do that, I will do a
manual diff myself.

Original comment by codedr...@gmail.com on 29 Mar 2010 at 1:23

GoogleCodeExporter commented 9 years ago 
Anas,

I tried to look at your changes, but at least in svgcanvas.js it seems that many
lines show changes (even though there are none).  This is usually due to 
space-vs-tab
differences in text editors.  We use tabs in svg-edit.

Nonetheless, I tried your changes and they seem to work until you rotate the 
text
elements.  If you can make it work ewhen the text is also rotated, then I would
consider merging your patch in.

Original comment by codedr...@gmail.com on 29 Mar 2010 at 3:50

GoogleCodeExporter commented 9 years ago 
Issue 726 has been merged into this issue.

Original comment by adeve...@gmail.com on 27 Oct 2010 at 6:34