search

gouthambs / Flask-Blogging

A Markdown Based Python Blog Engine as a Flask Extension.
http://flask-blogging.readthedocs.org/en/latest/
MIT License
688 stars 159 forks source link

Added Google Cloud Datastore support. #123

Closed agiUnderground closed 5 years ago

agiUnderground commented 5 years ago

Hi!

You can also ask Speedy1991 to accept my PR and we will have Google Cloud Storage + Google Cloud Datastore support.

gouthambs commented 5 years ago

Thanks. I will take a look later this week.

arshak commented 5 years ago

perhaps the example app we should explicitly set FILEUPLOAD_GCS_BUCKET otherwise the user will just get an ACL error about flask_blogging bucket access

arshak commented 5 years ago

The example app references

engine = create_engine('sqlite:////tmp/blog.db')

Why is SQLite db still necessary?

agiUnderground commented 5 years ago

The example app references

engine = create_engine('sqlite:////tmp/blog.db')

Why is SQLite db still necessary?

I fixed it.

agiUnderground commented 5 years ago

perhaps the example app we should explicitly set FILEUPLOAD_GCS_BUCKET otherwise the user will just get an ACL error about flask_blogging bucket access

We don't need to do this, the following code ensures that there is a default value(Flask-FileUpload): self.bucket_name = app.config.get("FILEUPLOAD_GCS_BUCKET", "flask_fileupload")

Also check a service account permissions.

gouthambs commented 5 years ago

This is great feature @agiUnderground .. Thanks for your contribution ..