gouthambs / Flask-Blogging

A Markdown Based Python Blog Engine as a Flask Extension.
http://flask-blogging.readthedocs.org/en/latest/
MIT License
688 stars 159 forks source link

Release new version #150

Closed mar1ad closed 2 years ago

mar1ad commented 2 years ago

147 fixes a security bug in SQLAlchemy

148 makes it possible to upgrade to Flask 2.x

149 Re-enables unittesting for new versions on Pypi

mar1ad commented 2 years ago

Hi @gouthambs,

You've succesfully uploaded a 2.0.0 version to test.pypi.org at your first run: https://github.com/gouthambs/Flask-Blogging/actions/runs/1837251494

Subsequent attempts failed despite new tags, because the version wasn't updated in flask_blogging/init.py accordingly.

May I suggest to remove the Flask version from Requirements.txt as well? Leave it up to the user to upgrade Flask.

gouthambs commented 2 years ago

Ah I was wondering why the error. Yes not forcing Flask 2 makes sense. I will update for post2 release.

On Mon, Feb 14, 2022 at 4:43 AM mar1ad @.***> wrote:

Hi @gouthambs https://github.com/gouthambs,

You've succesfully uploaded a 2.0.0 version to test.pypi.org at your first run: https://github.com/gouthambs/Flask-Blogging/actions/runs/1837251494

Subsequent attempts failed despite new tags, because the version wasn't updated in flask_blogging/init.py accordingly.

May I suggest to remove the Flask version from Requirements.txt as well? Leave it up to the user to upgrade Flask.

— Reply to this email directly, view it on GitHub https://github.com/gouthambs/Flask-Blogging/issues/150#issuecomment-1039042942, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAF7S6GFGVJC56XKISMCMTU3D2I3ANCNFSM5LQRPKTQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

gouthambs commented 2 years ago

@mar1ad new version is out. Great work!

mar1ad commented 2 years ago

Thanks, maybe remove the v2.0.1 tag to prevent future collisions?