govCMS / GovCMS7

Current stable release of the main Drupal 7 GovCMS distribution, with releases mirrored at https://www.drupal.org/project/govcms
https://www.govcms.gov.au/
GNU General Public License v2.0
112 stars 76 forks source link

Escape Admin module breaks back to site navbar functionality #148

Open rooby opened 8 years ago

rooby commented 8 years ago

The back to site functionality from the Escape Admin module (https://www.drupal.org/project/escape_admin) was added to the Navbar module (https://www.drupal.org/project/navbar) as of Navbar 7.x-1.6. See https://www.drupal.org/node/2208473

If you have both modules enabled though the functionality breaks (without throwing errors).

Uninstalling the Escape Admin module fixes the problem.

I'm using GovCMS 7.x-2.0-beta8.

fiasco commented 8 years ago

I'm all for less modules - if Escape Admin is no longer needed - happy to roll it out of the distro. However, we must do this in a phased approach to ensure minimal site breakage:

aleayr commented 8 years ago

Good to know, as with @fiasco, I'm keen to minimise the amount of modules installed as well.

If someone submits a PR for this, assuming it ticks the boxes flagged by @fiasco above, it'll likely be merged in.

queenvictoria commented 7 years ago

==Step 1==

  1. Remove escape from .info file https://github.com/govCMS/govCMS/blob/7.x-2.x/govcms.info#L61
  2. Add hook_update to govcms profile module to uninstall escape and provide a Drupal message to inform the owner about the rationale.
  3. Into govcms profile module add a hook that watches for the installation of escape and provide a Drupal error message warning of the modules deprecation eg: escape_admin_enable or escape_admin_install
  4. Release

==Step 2==

  1. Remove module from the .make file https://github.com/govCMS/govCMS/blob/7.x-2.x/drupal-org.make#L40
  2. Release