govCMS / GovCMS7

Current stable release of the main Drupal 7 GovCMS distribution, with releases mirrored at https://www.drupal.org/project/govcms
https://www.govcms.gov.au/
GNU General Public License v2.0
112 stars 76 forks source link

Pathauto Persist is now obselete #69

Closed mstrelan closed 8 years ago

mstrelan commented 9 years ago

Pathauto 7.x-1.3 now includes the functionality of Pathauto Persistent State which is now obsolete. We should update to the latest version.

I'm not sure what to do about removing the old module from govCMS. The pathauto update safely migrates the pathauto_persist data and disables the module, but it doesn't uninstall it. If you simply remove the module then you can't uninstall it. Perhaps manually uninstall it via a hook_update_n() in one of the govcms modules?

fiasco commented 9 years ago

Yeah I agree that we do it with an update hook. I think that we'd also have to keep pathauto_persist in the codebase for at least one release until we could be assured that everyone has had the opportunity to uninstall the module.

typhonius commented 9 years ago

Could we follow a similar approach to that in #50 whereby we disable/uninstall pathauto persist (and remove it from the list of modules allowed to be enabled) in an update hook in one release. Then, in a following release we can remove it from the repo.

mstrelan commented 9 years ago

I don't think module_uninstall() exists. This also wouldn't cover the case where someone updates two versions in one hit.

typhonius commented 9 years ago

We'd have to use drupal_uninstall_modules(). For the govCMS platform, each site would be updated concurrently so no site would miss an update.

mstrelan commented 9 years ago

You'll also have to make sure pathauto_update_7006() runs before the govcms_update_N() function.

For the govCMS platform, each site would be updated concurrently so no site would miss an update.

Theoretically anyone can download the installation profile from drupal.org and update as they please, so I guess it depends if you want to support that or not.

aleayr commented 8 years ago

355 is merged.