search

govCMS / GovCMS7

Current stable release of the main Drupal 7 GovCMS distribution, with releases mirrored at https://www.drupal.org/project/govcms
https://www.govcms.gov.au/
GNU General Public License v2.0
113 stars 76 forks source link

[GOVCMSD7-214] Update webform 7.x-4.19 (from 7.x-4.16) #871

Closed fubarhouse closed 5 years ago

fubarhouse commented 5 years ago

Testing has identified a compatibility problem with count() between the active version of webform and PHP 7.2, and testing has shown that the problem has since been resolved.

One step closer to PHP 7.2 support!

Note that the described issue has been addreddes as of #2953662 by CrashTest_, g089h515r806, Liam Morland: Only use count() on countables addressed as of 7.x-7.18. See drupal.org issue for more information.

The error being shown when submitting a webform v4.16 against PHP 7.2 as follows:

Warning: count(): Parameter must be an array or an object that implements Countable in _webform_client_form_validate() (line 3097 of /app/profiles/govcms/modules/contrib/webform/webform.module).
Warning: count(): Parameter must be an array or an object that implements Countable in _webform_client_form_validate() (line 3097 of /app/profiles/govcms/modules/contrib/webform/webform.module).
Warning: count(): Parameter must be an array or an object that implements Countable in _webform_client_form_validate() (line 3097 of /app/profiles/govcms/modules/contrib/webform/webform.module).
Warning: count(): Parameter must be an array or an object that implements Countable in _webform_client_form_validate() (line 3097 of /app/profiles/govcms/modules/contrib/webform/webform.module).

webform 7.x-4.19

Release notes

Progress Bars

Progress bars on single-page forms, which were enabled by default in 7.x-4.18, will be disabled in 7.x-4.18 by webform_update_7431(); see #2992404: Progress bar displays in single-page forms since 7.x-4.18.

Changes

7.x-4.18-rc1 released as 7.x-4.18. Changes since 7.x-4.18:

Coding standards
#2992404 by joelstein, rschwab, RamonOliveira, Liam Morland, joegraduate: Remove progress bar from single-page Webforms
#2948996 by snehal.addweb, Liam Morland, joelpittet: Fix Undefined index: source_type in webform_conditional_element_add()
#3005185 by goron: Check that block module is enabled before calling block_flush_caches()
#3001604 by Liam Morland: Use $account instead of $user in webform_submission_access()
#2996933 by DanChadwick: Added views submission data relationship handler support for cid only and form_key joins.

webform 7.x-4.18

Release notes

Progress bars

In Webform 7.x-4.18, single-page forms that do not have a preview page will now have a progress bar by default. This can be turned off in form settings. See #2992404: Progress bar displays in single-page forms since 7.x-4.18.

If you want to remove progress bars from all single-page forms that do not use a preview page, run the following SQL query on your site's database. This restores the pre-7.x-4.18 behavior. It can be run before or after the upgrade.

UPDATE webform SET progressbar_include_confirmation = 0 WHERE preview = 0 AND nid NOT IN (SELECT DISTINCT nid FROM webform_component WHERE type = 'pagebreak')

Changes

7.x-4.18-rc1 released as 7.x-4.18. Changes since 7.x-4.17:

#2842513 by richgerdes, Liam Morland: Always set default operator in _webform_conditional_expand()
Coding standards
#2995305 by idebr: Remove 'continue' not in the 'loop' or 'switch' context
#2994380 by Liam Morland: Create _webform_submission_prepare_mail()
#2994150 by Liam Morland, DanChadwick, quicksketch: Move preparation of drupal_mail() variables outside of loop
#2892494 by pcambra, Liam Morland: Follow Reply-To setting even when email is in the default domain
#2891776 by aalin, Liam Morland: Use webform_component_include() instead of module_load_include()
#2881423 by MrDaleSmith: Use DateTime objects in submission export date ranges
#1147994: Refactor component rendering
#2984733 by Liam Morland: Document the use of 'private' in hook_webform_component_info()
#2953662 by CrashTest_, g089h515r806, Liam Morland: Only use count() on countables
#2979444 by gaele, jacob.embree: Depend on Rules update only if Rules module enabled
#2976131 by kpaxman: Make minutes default to "minute" in time components
#2895892: Make tests compatible with PHP 5.3
#2895892 by torotil: Delete conditionals when deleting components in webform_node_update()
#2948705 by torotil: Document callback_webform_conditional_rule_value_form()
#2948705 by torotil: Document callback_webfom_conditional_comparison_operator()
#2948705 by torotil: Document hook_webform_conditional_operators_alter()
#2948705 by torotil: Document hook_webform_conditional_operator_info()
#2954590: Only run webform_page_labels() when needed
#2954590 by katzmo: No progress bar on single page forms even when confirmation page included

webform 7.x-4.17

Release notes

Warning: Some users are reporting that file attachments are not working after this update, see #2966816: Attachments don't work. There is no update hook, so you can safely try the new version and revert if you have a problem.

Changes

7.x-4.17-rc1 released as 7.x-4.17. Changes since 7.x-4.16:

#2955275 by Liam Morland: Remove Mollom-specific code
#2954685 by Liam Morland: Add label elements on conditionals page
#2816835 by joelstein, RoshniPatel.addweb: Add $form and $form_state to component edit callback
#2953052 by jacob.embree: Remove pass-by-reference in webform_get_cid()
#2949485 by Liam Morland: Set default values for all parameters following those with defaults
Coding standards
#2949342 by torotil: Fix comparison bug in webform_compare_select()
#2948661 by torotil: Fix erroneous type-hinting
#2674978 by joseph.olstad, steve.m: Fix update 7420 during D6 to D7 upgrade
#2914782 by dpi, larowlan: Performance improvement in webform_node_view()
#2921029 by jacob.embree: Remove Mimemail compatibility shim
#2923461 by poiu, Vj: Load token module files only if it is enabled
#2926646 by DanChadwick: Make JS for conditionals work with "show" and "set" on the same component
#2931151 by geoffray: Respect expose_php directive in X-Mailer email header
#2521760 by quiron, plinto: Make conditionals compatible with Chosen module
#2918516 by vinmassaro: Create the webform_export_path directory if it does not exist
Coding standards: Comments
#2915789 by Liam Morland: Match superclass signature in subclasses of webform_exporter for add_row()
#2915789-2 by DanChadwick: Match superclass signature in subclasses of webform_exporter for method add_row.
#2917877 by DanChadwick: Allow some grid questions to be made programmatically optional.
Coding standards: Remove code following 'return' statements
Refactor: Reformat long conditionals
Coding standards: Remove @file from files containing only one class definition
Fix typo in output string
#2913891 by bryden: Add @col to grid component table headers
#2915789 by Liam Morland: Add "array" type hints
Coding standards: Align @param documentation with function signatures
Coding standards: Adjust comments
Coding standards: Replace key_exists() with array_key_exists()
Coding standards: Remove files[] entry for file that does not contain class
fubarhouse commented 5 years ago

Will update shortly with a changelog. edit: edited original post.

fubarhouse commented 5 years ago

This PR duplicates #845.

There's better context, descriptions and labels describing the affected issues however so this one can supersede #845 however given the change is identical only one can be merged.