search

govCMS / GovCMS7

Current stable release of the main Drupal 7 GovCMS distribution, with releases mirrored at https://www.drupal.org/project/govcms
https://www.govcms.gov.au/
GNU General Public License v2.0
113 stars 76 forks source link

Upgrade xmlsitemap to 7.x-2.6 #890

Closed sonnykt closed 2 years ago

sonnykt commented 4 years ago

Version 2.5 has a critical issue https://www.drupal.org/project/xmlsitemap/issues/2986847 which breaks the sitemap and may break system cron as well. ASADA has reported the issue on their site https://www.govcms.support/a/tickets/3651. Disabling then re-enabling the module fixes the issue temporarily, but the module needs to be upgraded to 2.6 to permanent fix the issue.

tobybellwood commented 4 years ago

fixed when #849 gets merged

seanhamlin commented 4 years ago

Just encountered another site with issues running cron:

2019-11-04T21:16:20Z CRONJOB: drush cron
Agent pid 20
Identity added: /home/.ssh/key (/home/.ssh/key)
WD php: TypeError: Argument 1 passed to xmlsitemap_node_create_link()    [error]
must be an instance of stdClass, boolean given, called in
/app/profiles/govcms/modules/contrib/xmlsitemap/xmlsitemap_menu/xmlsitemap_menu.module
on line 282 in xmlsitemap_node_create_link() (line 219 of
/app/profiles/govcms/modules/contrib/xmlsitemap/xmlsitemap_node/xmlsitemap_node.module).
TypeError: Argument 1 passed to xmlsitemap_node_create_link() must be an instance of stdClass, boolean given, called in /app/profiles/govcms/modules/contrib/xmlsitemap/xmlsitemap_menu/xmlsitemap_menu.module on line 282 in xmlsitemap_node_create_link() (line 219 of /app/profiles/govcms/modules/contrib/xmlsitemap/xmlsitemap_node/xmlsitemap_node.module).
Drush command terminated abnormally due to an unrecoverable error.       [error]

This causes the cron pod to fail.

thisisalistairsaccount commented 2 years ago

Closing issue. Module had been updated previous to 2.6