search

govCMS / GovCMS7

Current stable release of the main Drupal 7 GovCMS distribution, with releases mirrored at https://www.drupal.org/project/govcms
https://www.govcms.gov.au/
GNU General Public License v2.0
113 stars 76 forks source link

[feature/GOVCMS-3905] Use TugboatQA to build PR test environments for distro/modules/themes #898

Closed drupal-spider closed 4 years ago

simesy commented 4 years ago

AMDS can you please remove all the boilerplate comments from settings.php they just make it hard to eyeball a file and determine what is custom. Please see https://github.com/govCMS/govCMS8/blob/1.x/.tugboat/settings.php

I usually link to the canonical settings file, which means we don't need maintain duplicate code. https://github.com/govCMS/govCMS8/blob/1.x/.tugboat/settings.php#L8

drupal-spider commented 4 years ago

AMDS can you please remove all the boilerplate comments from settings.php they just make it hard to eyeball a file and determine what is custom. Please see https://github.com/govCMS/govCMS8/blob/1.x/.tugboat/settings.php

I usually link to the canonical settings file, which means we don't need maintain duplicate code. https://github.com/govCMS/govCMS8/blob/1.x/.tugboat/settings.php#L8

Sure. Just clean up all comments.

drupal-spider commented 4 years ago

AMDS can you please remove all the boilerplate comments from settings.php they just make it hard to eyeball a file and determine what is custom. Please see https://github.com/govCMS/govCMS8/blob/1.x/.tugboat/settings.php

I usually link to the canonical settings file, which means we don't need maintain duplicate code. https://github.com/govCMS/govCMS8/blob/1.x/.tugboat/settings.php#L8

Thanks @simesy , the reference to the canonical setting file is added to the beginning of the setting file.