govCMS / audit-site

govCMS site audit and remediation tool. Used to verify all sites built in, and for GovCMS SaaS meet the minimum requirements.
4 stars 4 forks source link

"Page Cache Control Max Age Failed" false positive #21

Closed ellioseven closed 6 years ago

ellioseven commented 6 years ago

When running an audit, I get:

Page Cache Control Max Age Failed 
Ensure you page cache expiry is set to an optimal level for best performance.
Page cache max-age is not set above 300 seconds. Currently set to 0.
Remediation
Set the variable page_cache_maximum_age to be greater than 300.

However when running drush vget page_cache_maximum_age I get:

page_cache_maximum_age: 300

Is there something I am doing wrong here?

fiasco commented 6 years ago

Could you set it to 301? I'm curious to know if its because of an > evaluation opposed to a >= operator.

ellioseven commented 6 years ago
drush vset page_cache_maximum_age 301

Still gives me:

image

fiasco commented 6 years ago

I found the bug! Sorry this took soo long but is now fixed in the latest dev of the drutiny/plugin-drupal-7 branch.