govCMS / govCMS8-UI

[Experimental] Theme (based on DTA UI-kit version 2.x) for a govCMS Drupal 8 distribution
3 stars 4 forks source link

Site logo is hard coded in template #4

Open pandaskii opened 6 years ago

pandaskii commented 6 years ago

Template:

govcms-ui/templates/includes/_header.html.twig

<img src="/themes/contrib/govcms-ui/govcms-ui/logo.svg" alt="Home" height="70">

imperator99 commented 6 years ago

Hey @pandaskii what result are you after for this one? I'm happy to work on it but just want to check.

pandaskii commented 6 years ago

@imperator99 thanks for the help please go for it.

We had few big changes during the weekend

https://github.com/govCMS/uikit-bootstrap

https://github.com/govCMS/govCMS8-ui/tree/master/govcms-ui/src/sass

bash build/update_uikit_bootstrap.sh

imperator99 commented 6 years ago

Thanks @pandaskii. Can you let me know what the final result will be? I'm expecting the user to do the following:

Does that cover it off? Cheers, Jesse.

pandaskii commented 6 years ago
screen shot 2017-10-30 at 15 19 46

Yes, I think they are covered

imperator99 commented 6 years ago

Okay cool, I'm working on it now (assuming that's a mock-up and not something that already exists).