govCMS / govcms8_uikit_starter

GovCMS 8 UI-Kit Starter
10 stars 16 forks source link

Notice: Undefined index: region in govcms8_uikit_starter_preprocess_block() #121

Open OPCIT opened 4 years ago

OPCIT commented 4 years ago

When assigning a menu to one or all of the 'Postscript' regions we are getting this error.

Notice: Undefined index: region in govcms8_uikit_starter_preprocess_block() (line 243 of themes/contrib/govcms8_uikit_starter/govcms8_uikit_starter.theme).

Disabling the menu in the regions removes the error.

OPCIT commented 4 years ago

Oh and this is only occurring on local devs, not in Sandbox which makes it more weird.

OPCIT commented 4 years ago

Code needs updating: govcms8_uikit_starter.theme (line 242)

` /**

if (isset($variables["content"]["#menu_block_configuration"])) {

should be

if (isset($variables["content"]["#menu_block_configuration"]["region"])) {

OPCIT commented 4 years ago

Any update on having this issue corrected, or is it an edge case error?

Belhendo commented 4 years ago

hi @OPCIT

We're currently reviewing this internally to find a way to progress. It seems to be an edge case error at this stage.

Belhendo commented 4 years ago

Hi @OPCIT

Due to resource limitations at our end, our suggestion to progress this is as follows:

Thanks @OPCIT

OPCIT commented 4 years ago

@Belhendo

Seems this is no longer the case.

_Hi Stephen, The govcms8_uikitstarter repo is locked and it is not possible to push directly to it. You could forklift the project in Github and create a pull request, however, Finance team has advised me that there are no planned releases in near feature. We recommend forking the theme in your local projects and not depend on the Github project. Please let me know if you have any question or concern. Kind regards, Ahmed.

thisisalistairsaccount commented 4 years ago

@OPCIT I think the fork is going to be the best option as per Ahmed's message. We do not have any planned releases for the kit.