Update main and side nav components. Remove aria-selected from side nav.

govCMS / govcms8_uikit_starter

GovCMS 8 UI-Kit Starter

10 stars 16 forks source link

Update main and side nav components. Remove aria-selected from side nav. #89

Closed petrillek closed 4 years ago

petrillek commented 5 years ago

PR for #88

I was thinking a lot about the templates for bot main and side navigation and in the end removed them from the UI-Kit template folder. Main reason is that inside UI_kit there should be only clean Desing System component without any "drupalisms" (or with only limited one). Menus contain a custom Drupal link function. The menu template on itslef may probably have a lot of different templates according to the system where it is used. Therefore some "generic" template is not needed.

petrillek commented 5 years ago

I've found out that after updating to Drupal 8.7 the link_attributes will throw an assertion error if empty. Fixed in similar way as described here: https://www.drupal.org/project/menus_attribute/issues/3053598