search

govCMS / scaffold-tooling

6 stars 17 forks source link

[GOVCMSD9-716] Lagoon support for PHP8 #196

Closed pandaskii closed 2 years ago

tobybellwood commented 2 years ago

What's the actual difference here - is it PHP8 or phpredis5 - we have the same logic in our d8 example (albeit not running on PHP8) that we should probably also change then? https://github.com/amazeeio/drupal-example-simple/blob/9.x-advanced/assets/all.settings.php#L75

stooit commented 2 years ago

It's phpredis5, which came with the upstream AIO PHP8.1 image (current 7.x images have phpredis 4.3.0)

Your example project is pinned to 7.4 atm so likely not relevant there until you bump to 8.1 too - can throw a PR your way later if you like

tobybellwood commented 2 years ago

Thankfully haven't ported redis across to the php8-based examples yet - will make sure to include this when I do!