search

govCMS / scaffold-tooling

6 stars 17 forks source link

Fix: Update cookie_samesite configuration. #273

Closed steveworley closed 1 year ago

silverham commented 1 year ago

This is actually incorrect, the proper fix is to set the intended drupal core value as per https://git.drupalcode.org/project/drupal/-/blob/10.1.1/core/core.services.yml#L12, as govms accsdienly overrides the whole array in drupal/settings/all.services.yml.

However, the fix is only required in D10, not D9 as the drupal commit is on D10 only. @see https://www.drupal.org/node/3275352

See my pull request for D10 [#275]

steveworley commented 1 year ago

Thanks @silverham — I did try that but it wasn't working. I'll review your PR now and get that merged in! Thanks!