govCMS / scaffold-tooling

6 stars 17 forks source link

[DEVOPS-279] Required Drush 12. #289

Closed sonnykt closed 11 months ago

sonnykt commented 1 year ago

Companion PRs:

steveworley commented 1 year ago

Hey @sonnykt can you review the failing test?

sonnykt commented 11 months ago

hey @steveworley

# Your requirements could not be resolved to an installable set of packages.
#
#   Problem 1
#     - Root composer.json requires govcms/scaffold-tooling 10.x-master-dev -> satisfiable by govcms/scaffold-tooling[dev-10.x-master].
#     - govcms/scaffold-tooling dev-10.x-master requires drush/drush ~9 || ~10 || ~11 -> found drush/drush[9.0.0-alpha1, ..., 9.x-dev, 10.0.0-alpha1, ..., 10.x-dev, 11.0.0-rc1, ..., 11.x-dev] but it conflicts with your root composer.json require (^12).

It seems that when CI builds scaffold it still requires govcms/scaffold-tooling dev-10.x-master which doesn't have Drush 12.

steveworley commented 11 months ago

hey @steveworley

# Your requirements could not be resolved to an installable set of packages.
#
#   Problem 1
#     - Root composer.json requires govcms/scaffold-tooling 10.x-master-dev -> satisfiable by govcms/scaffold-tooling[dev-10.x-master].
#     - govcms/scaffold-tooling dev-10.x-master requires drush/drush ~9 || ~10 || ~11 -> found drush/drush[9.0.0-alpha1, ..., 9.x-dev, 10.0.0-alpha1, ..., 10.x-dev, 11.0.0-rc1, ..., 11.x-dev] but it conflicts with your root composer.json require (^12).

It seems that when CI builds scaffold it still requires govcms/scaffold-tooling dev-10.x-master which doesn't have Drush 12.

Yeah — I saw that yesterday when I was trying to unblock the pipeline. I think we accept the automated test failure for now and resolve once we get this through to master.

Thanks for reviewing.

simesy commented 11 months ago

If you're on PaaS debugging drush launcher and find yourself here, you need to apply soemthing lik this to your site https://github.com/govCMS/scaffold/commit/5ac3b14ceb5bfa126cb438a5b97d99eeee384b20