Rules List

govariantsteam / govariants

A place to play Go variants

https://www.govariants.com

GNU Affero General Public License v3.0

5 stars 1 forks source link

Rules List #340

Closed merowin closed 3 days ago

merowin commented 4 days ago

This adds a new view that is linked to in the NavBar and has links to the rules page for variants with a (detailed) rules description. Also I've added the demo board to the rules view as proposed in https://github.com/govariantsteam/govariants/issues/112 I wasn't able to make sure that the demo board fits, so I made its container scrollable on overflow.

grafik

Rules Page

grafik

benjaminpjones commented 4 days ago

Very nice! These go great together, and I'm glad we're finally linking them from the main page.

I haven't had a chance to look at the code, but some visual thoughts:

Text is a bit wide IMO.
- I searched around, and there is no one-size-fits-all approach. However, most readability guidelines fall in the 45-90 characters range, whereas this is about 130 characters long.
- Narrowing the text may also solve the space issue for the demo board as well.
On mobile, text could use some margin - I think it's like 3 px now, I'd recommend at least 8px
- Compare Medium.com, which gives 24px on mobile
- This might actually be some feedback for the website in general (config form also seems a bit cramped without margin), so we don't need to address in this PR

merowin commented 3 days ago

* Text is a bit wide  IMO.

  * I searched around, and there is no one-size-fits-all approach.  However, most readability guidelines fall in the 45-90 characters range, whereas this is about 130 characters long.
  * Narrowing the text may also solve the space issue for the demo board as well.

* On mobile, text could use some margin - I think it's like 3 px now, I'd recommend at least 8px

  * Compare Medium.com, which gives 24px on mobile
  * This might actually be some feedback for the website in general (config form also seems a bit cramped without margin), so we don't need to address in this PR

Thanks for the feedback! I've increased the padding on mobile to 12px (for all pages using grid-page-layout), and added some limits for the width of the text column.