Open HerinHentry opened 6 years ago
Also, the thicker borders when used in different colour themes - High Contrast white / High Contrast black is overpowering. When there are multiple controls in the form the label is almost lost in the middle of the thicker borders.
@HerinHentry these are all great suggestions I really appreciate you going through the design system and providing feedback it's awesome 👍.
We probably won't add multiple different types of form controls to the design system documentation website as this will make it more difficult to understand. There might be room in the rationale section or potentially new variations.
One thing which we hope to do in the future is create a form template which would showcase these indicators you have mentioned.
I do agree that the labels are not as impactful against the thick borders in the input i'll see what we can do!
Are you basing the design on any existing design systems?
@HerinHentry the design is trying to be as consistent to the other components. The original design was based off work done when developing gov.au
When we have to design a new component or make design changes we often look at best practices from other design systems such as bootstrap and try balance them with WCAG AA guidelines. If we have similar patterns already in the design system we would look at those as well.
This also should look into passwords and guidance for password inputs.
Regarding Text Inputs https://designsystem.gov.au/components/text-inputs/live/
Form controls have other indicators like mandatory error value read-only input etc
Also, inputs that are grouped together by the same label - Credit card etc.
Can we please include examples for this as well?