govau / design-system-components

🛠 Component code and tests for the Australian Government design system

https://auds.service.gov.au

MIT License

739 stars 111 forks source link

AU-space not calculating correct REM if $AU-rem has been changed #883

Open mikey0000 opened 5 years ago

mikey0000 commented 5 years ago

Bug Report

[ x] I’ve read and understood the Contributing guidelines and have done my best effort to follow them.
[ x] I’ve read and agree to the Code of Conduct.
[x ] I’ve searched for any related issues and avoided creating a duplicate issue.

What happened

Set $AU-rem to 14, select box height gets set to AU-space('height', 2.5unit) height: 40px height: 2.5rem

What I expected to happen

Set $AU-rem to 14, select box height gets set to AU-space('height', 2.5unit) height: 40px height: 2.875rem

Reproducing

Module name: Select
Module version: latest
Pancake version:N/A
Node version:N/A
npm version:N/A
Pancake settings in your package.json:

Steps to reproduce:

Set $AU-rem: 14;
Run the test suite for Select
select the HTML version and set HTML font-size: 14px
view REM vs Height in inspector

It looks that the AU-space function doesn't take into account the $AU-rem setting.

Attachments

KiriHoy commented 5 years ago

Hi @mikey0000 thanks for raising the issue! The team will have a look into it and get back to you