Intermittent npm audit fix errors

[mrrossmullen]

Bug Report

• [x] I’ve read and understood the Contributing guidelines and have done my best effort to follow them.
• [x] I’ve read and agree to the Code of Conduct.
• [x] I’ve searched for any related issues and avoided creating a duplicate issue.

What happened

Running npm audit fix within packages/callout displays:

✗ Some package.json files contain inconsistencies: The module callout has the pancake config saved though we don’t want that…

Additionally different Mac/PC and Node/npm versions don't display the error universally.

What I expected to happen

npm audit fix to complete successfully and update dependencies.

Reproducing

• Module name: @gov.au/callout
• Module version: 3.0.2
• Pancake version: 1.0.0
• Node version: 14.15.4
• npm version: 6.14.10
• Pancake settings in your package.json:

Steps to reproduce:

1. cd packages/callout
2. npm audit fix

Attachments

> node ../../scripts/helper.js test

✔︎  All pancakes without dependency conflicts
✗  Some package.json files contain inconsistencies:
   The module callout has the pancake config saved though we don’t want that…

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @gov.au/callout@3.0.2 test:helper: `node ../../scripts/helper.js test`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @gov.au/callout@3.0.2 test:helper script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\IEUser\AppData\Roaming\npm-cache\_logs\2021-02-15T00_07_04_423Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @gov.au/callout@3.0.2 prepublish: `npm run test:helper && npm run build:pre`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @gov.au/callout@3.0.2 prepublish script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

[mrrossmullen]

Error isolated to testing for pancake conditional logic in helper.js where the auto-save key existence is checked in package.json

// testing for pancake config
if( packagesPKG.pancake['auto-save'] !== undefined ) {
error += `The module ${ module } has the pancake config saved though we don’t want that…\n`;
}

Removal of this conditional check causes npm audit fix to complete successfully. However, a more permanent solution needs to be identified.

[mrrossmullen]

Incorrect understanding of the build process results in this error. As a component producer (DTA) npm audit fix shouldn't be run within the packages, update package.json and package-lock.json using ncu https://www.npmjs.com/package/npm-check-updates