search

govau / service-manual

Digital Guides
https://guides.service.gov.au
MIT License
15 stars 18 forks source link

Remove package-lock.json from .gitignore #180

Closed alex-page closed 6 years ago

alex-page commented 6 years ago

We initially put the package-lock.json file into the .gitignore so that users of the service manual didn't accidentally commit it with their content changes.

This needs to be removed as we will one day want to lock versions so we have exact dependencies across all users of the service manual.

https://docs.npmjs.com/files/package-lock.json

It describes the exact tree that was generated, such that subsequent installs are able to generate identical trees, regardless of intermediate dependency updates.

dominikwilkowski commented 6 years ago

hey @marksantoso ... Can you please remove the package-lock.json from the ignore? It is a secops requirement.

marksantoso commented 6 years ago

returned package-lock.json