search

govdirectory / website

Website repository for Govdirectory - a crowdsourced and fact-checked directory of official governmental online accounts and services.
https://govdirectory.org
Creative Commons Zero v1.0 Universal
48 stars 33 forks source link

Improve pull request template #442

Open Ainali opened 1 week ago

Ainali commented 1 week ago

Description

For many of my latest PRs which have been updating queries to either match new modeling choices on Wikidata or a changed reality (new ministries etc.) the types have not felt great. It is neither a bug nor a new feature. Could we add a type called query maintenance or something similar?

Abbe98 commented 1 week ago

We should properly have an "other" option.

Ainali commented 1 week ago

Come to think on it, should it really be a checkbox? Wouldn't a reminder text about setting a label be better? (Can new users see the available labels?)

Abbe98 commented 1 week ago

Should external contributors be responsible for classifying/labeling pull requests to begin with? It's not like that is the task which saves us time...

Ainali commented 1 week ago

That's a really good point. Perhaps we should remove that entire section from the template, and then the first reviewer assigns labels if needed.

Abbe98 commented 1 week ago

Yeah I think so.