Resolve cwd symlinks before checking if we're in $GOPATH/src

govend / govend

A simple tool to vendor Go package dependencies. It's like "go get" for vendoring.

Apache License 2.0

226 stars 30 forks source link

Resolve cwd symlinks before checking if we're in $GOPATH/src #51

Closed uberbrodt closed 8 years ago

uberbrodt commented 8 years ago

I have a single GOPATH and symlinks to my projects in its root. where $GOPATH/foo -> $GOPATH/src/github.com/uberbrodt/foo. Code now checks if cwd is a symlink to something in $GOPATH/src.

Tested on Mac OS X

jackspirou commented 8 years ago

@uberbrodt thanks!

gustav-b commented 8 years ago

Don't you need to resolve the cwd symlink for filters too? I.e. in projectImportPath() in imports/filters/filters.go?

uberbrodt commented 8 years ago

@gustav-b Hmm, possibly. I didn't have an issue when testing. I think it might show up if you run govend in a symlinked source path that is not go get-able?