goveo / react-international-phone

☎️ International phone input component for React
https://react-international-phone.vercel.app/
MIT License
277 stars 54 forks source link

Undo/redo shortcuts use Windows-style modifier keys, even on macOS #179

Closed jessetan closed 5 months ago

jessetan commented 5 months ago

Describe the bug It is possible to undo/redo edit changes using ctrl-Z and shift-ctrl-Z. This works on both Windows and macOS. However on macOS, the idiomatic shortcut for undo/redo is command-Z and shift-command-Z

To Reproduce Steps to reproduce the behavior:

  1. Type in a phone number on a mac
  2. Press command-Z
  3. Observe nothing happens

Expected behavior

Expected:

  1. The last change is reverted

Desktop (please complete the following information):

Additional context The JavaScript property for the macOS command key is metaKey https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/metaKey

goveo commented 5 months ago

:tada: This issue has been resolved in version 4.2.9 :tada:

The release is available on:

Your semantic-release bot :package::rocket: