feat(countryselector button props): enables passing through props to …

goveo / react-international-phone

☎️ International phone input component for React

https://react-international-phone.vercel.app/

MIT License

277 stars 54 forks source link

feat(countryselector button props): enables passing through props to … #192

Open ccummings-iddw opened 3 months ago

ccummings-iddw commented 3 months ago

…the country selector button

What has been done

Adds a new prop to the PhoneInput component called countrySelectorButtonProps which allows the developer to pass in relevant props directly to the button element in the CountrySelector component

Checklist before requesting a review

[x] I have read the contributing doc before submitting this PR.
[x] Commit titles correspond to the convention.
[x] I have performed a self-review of my code.
[x] Tests for the changes have been added (for bug fixes/features).
[x] Docs have been added / updated (for bug fixes / features).

Screenshots (if appropriate):

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-international-phone-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 9, 2024 3:02pm
react-international-phone-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 9, 2024 3:02pm

ccummings-iddw commented 2 months ago

@goveo Any chance you could take a look at this PR? Or is there a different approach that is already available that has this same functionality?

I want to add this functionality to be able to override fields/html attributes on the button element such as aria-label, id, etc..

ccummings-iddw commented 1 month ago

@goveo - sorry for the delay. updated to include docs change. I can't seem to remove the pnpm-lock.yaml file changes, I believe its just whitespace changes... can we merge this anyways?