govfresh / govpress

The WordPress theme for government
https://wordpress.org/themes/govpress/
GNU General Public License v2.0
135 stars 51 forks source link

Color customization options #1

Closed lukefretwell closed 10 years ago

lukefretwell commented 10 years ago

Add theme options so base color can be changed.

Perhaps incorporating this?

http://wptheming.com/2012/07/options-framework-theme-customizer/

alaina13 commented 10 years ago

I attended a webinar this past weekend on themes; they touched on customization a bit especially around using the built in Wordpress customizer. I think this is a great idea so that people don't have to worry about child theming. It would take some of the customization off of your hands too or at least let municipalities change things later on more easily. I would love to see this built out in other words!

devinsays commented 10 years ago

I can give a pull request for this. Busy this week, but I'll try for next.

lukefretwell commented 10 years ago

@devinsays Awesome.

@alaina13 asked about being able to add a background image for the homepage hero unit.

I don't want to overcomplicate this and wear out my welcome, but I'm wondering what would be best way to understand an MVP spec. @devinsays, would also love feedback on how other aspects might fold into theming options (header image/background) or should those stay as is.

lukefretwell commented 10 years ago

What if, for starters, we added a basic color picker with dark colors? That way we could just change the default blue without worrying about a lighter color on white text issue.

Or are you thinking this is best left until after we submit to wordpress.org?

devinsays commented 10 years ago

Let's do customization options after v1 is browser tested and submitted to wp.org.

The colorpicker can't be limited to a certain range. Customization options get complicated quickly. If there is a background customization options for an element, text colors and link colors also need customization options (to avoid light/dark unreadable text). Menus, with their backgrounds, text colors, hover states, and drop down backgrounds are especially difficult.

devinsays commented 10 years ago

I committed a set of color customization options that I think will handle most use cases. See: 4364a3b

The color options are:

There are other places color options could be added (of course), but I think this risks taking us down a rabbit hole of customization options. If people would like to style the menu drop down backgrounds, menu hover states, footer widget header colors, etc. I think this would be best addressed by a child theme.

Thoughts @lukefretwell? Please test this out and let me know what you think.

lukefretwell commented 10 years ago

Just uploaded and haven't played with it but now see a white section with a smiley face below the footer:

http://govpress.co/

lukefretwell commented 10 years ago

Love it!

Only issue is the hover link in the footer gets overridden by the custom link color.

Probably should be white/underline regardless. Poses issues if someone wants a lighter primary color, but not much we can do if want to keep customization simple. I don't have an issue with this.

Also, looks like the smiley face went away.

devinsays commented 10 years ago

The smiley is caused by the WordPress Stats (part of JetPack). I believe you can turn it off.

I'll test the footer link a bit more.

lukefretwell commented 10 years ago

Looks like it's happening on the default theme, too, which I didn't notice before. Just make hover white/underline and call it a day?

lukefretwell commented 10 years ago

Just tested latest version and this works great.