!important in style.css

[emiluzelac]

Just out of the curiosity, why heavy use of !important declaration in https://github.com/govfresh/govfreshwp/blob/master/style.css? I don't believe that you need them at all, not for some small stuff like changing fonts etc.

[lukefretwell]

Emil,

Wow, really appreciate you jumping into all this.

@devinsays is doing a major overhaul of the code, including moving away from Bootstrap. I add the !important declarations because it was the only way I could get things to work trying to get an MVP off the ground. You've already discovered by now my coding skills are fairly intermediate. :-)

You and @devinsays should connect to discuss how best to tackle. There's already interest internationally, so the pull requests and insights on that front are definitely helpful.

Really appreciate you taking an interest in this. We're coordinating with key folks in the community to do a broader push once the theme is more 'official' so we're expecting a ton of interest, especially given there's a huge need for something like this.

Luke

[emiluzelac]

Glad to help bud. With Devin you are in great hands. I will contribute more for sure.

Thanks, Emil On Jan 29, 2014 11:48 PM, "Luke Fretwell" notifications@github.com wrote:

Emil,

Wow, really appreciate you jumping into all this.

@devinsays https://github.com/devinsays is doing a major overhaul of the code, including moving away from Bootstrap. I add the !important declarations because it was the only way I could get things to work trying to get an MVP off the ground. You've already discovered by now my coding skills are fairly intermediate. :-)

You and @devinsays https://github.com/devinsays should connect to discuss how best to tackle. There's already interest internationally, so the pull requests and insights on that front are definitely helpful.

Really appreciate you taking an interest in this. We're coordinating with key folks in the community to do a broader push once the theme is more 'official' so we're expecting a ton of interest, especially given there's a huge need for something like this.

Luke

Reply to this email directly or view it on GitHubhttps://github.com/govfresh/govfreshwp/issues/18#issuecomment-33662052 .

[devinsays]

Hi @emiluzelac. I've been working to rebuild of this theme based on _s. I decided it would be faster than updating the current version piecemeal. I just pushed this work-in-progress into a branch: https://github.com/govfresh/govfreshwp/tree/theme-rebuild

Once it's working and the styling is finished, I'll merge into the master branch. At that point it could definitely use more eyes on it.

Luke, just to make introductions here, @emiluzelac is one of the leads for the Theme Review Team- a group of volunteers that audits all the themes before they can be posted to WordPress.org

[lukefretwell]

Great to meet you @emiluzelac. Can't say enough about how much I appreciate you both taking an interest in this. Some of it's a little over my head, but I'm trying to learn.

@emiluzelac, as I've said to @devinsays many times, thank you for dealing with my code. :-)

[emiluzelac]

Absolutely Devin, this sounds great, I am here when and if you need me. Luke, don't mention it, very glad to help even with the little stuff :)

On Thu, Jan 30, 2014 at 11:47 AM, Luke Fretwell notifications@github.comwrote:

Great to meet you @emiluzelac https://github.com/emiluzelac. Can't say enough about how much I appreciate you both taking an interest in this. Some of it's a little over my head, but I'm trying to learn.

@emiluzelac https://github.com/emiluzelac, as I've said to @devinsayshttps://github.com/devinsaysmany times, thank you for dealing with my code. :-)

Reply to this email directly or view it on GitHubhttps://github.com/govfresh/govfreshwp/issues/18#issuecomment-33712900 .