search

govfresh / govpress

The WordPress theme for government
https://wordpress.org/themes/govpress/
GNU General Public License v2.0
135 stars 51 forks source link

Submit button styling #40

Closed lukefretwell closed 10 years ago

lukefretwell commented 10 years ago

The submit button styling is overriding basic styles making it hard to read in some places.

Can we remove 'box-shadow' and 'text-shadow' styles here?

button, input[type="button"], input[type="reset"], input[type="submit"]

lukefretwell commented 10 years ago

Looks fine here: http://govfresh.com/about/contact/

But not here: http://govfresh.com/subscribe/

devinsays commented 10 years ago

Hi Luke. The problematic styling is coming from #mc_embed_signup (http://govfresh.com/subscribe/). Which plugin is this? Is it one that you are recommending for the site?

lukefretwell commented 10 years ago

I'm seeing it here:

http://govfresh.com/wp-content/themes/govpress/style.css?ver=3.8.1

On Sun, Mar 2, 2014 at 12:40 PM, Devin Price notifications@github.comwrote:

Hi Luke. The problematic styling is coming from #mc_embed_signup ( http://govfresh.com/subscribe/). Which plugin is this? Is it one that you are recommending for the site?

Reply to this email directly or view it on GitHubhttps://github.com/govfresh/govpress/issues/40#issuecomment-36465902 .

devinsays commented 10 years ago

I don't mind removing text-shadow/box-shadow. But the problematic display is primarily caused by MailChimp altering default styling: http://cdn-images.mailchimp.com/embedcode/classic-081711.css.

If you are planning to recommend MailChimp forms, this is something that could be styled around which is why I asked.

devinsays commented 10 years ago

I removed the text shadow, but will need to spend a little more time to design new hover states and backgrounds if box-shadows aren't used. The box-shadows currently used help indicate hover and focus states.

lukefretwell commented 10 years ago

OK. Great. Odd that MailChimp uses those styles. In the embed code preview, it's just flat with gray. Looks exactly like what you see when deselecting those two styles in inspect element.