search

govfresh / govpress

The WordPress theme for government
https://wordpress.org/themes/govpress/
GNU General Public License v2.0
135 stars 50 forks source link

header clear #41

Closed lukefretwell closed 10 years ago

lukefretwell commented 10 years ago

Do we want to have the clear on headers?

/* Headings */ h1, h2, h3, h4, h5, h6 { clear: both; }

When images are aligned left/right in posts it causes large whitespace gaps.

See: http://govfresh.com/2014/01/smartprocure/

devinsays commented 10 years ago

I am using the boilerplate styling in in Underscores (https://github.com/Automattic/_s/blob/master/style.css). Actually not sure if there are good reasons to clear headers in content except that people may expect block level elements to clear.

devinsays commented 10 years ago

We can test without headers clearing, but I am conflicted about removing them.

Clearing headers appears to be standard practice. TwentyFourteen (https://github.com/WordPress/WordPress/blob/master/wp-content/themes/twentyfourteen/style.css), TwentyThirteen (https://github.com/WordPress/WordPress/blob/master/wp-content/themes/twentythirteen/style.css).

Block level elements (like headers) clear by default: http://www.w3.org/MarkUp/html3/headings.html

I'll try to get some additional feedback on this ticket.

devinsays commented 10 years ago

Let's close this for now- I'd like to go with the standard practices here.