govfresh / govpress

The WordPress theme for government
https://wordpress.org/themes/govpress/
GNU General Public License v2.0
135 stars 50 forks source link

Search Input Doesn't Wrap Well #42

Closed devinsays closed 9 years ago

devinsays commented 10 years ago

Perhaps we should use negative margins to keep the so the submit button stays on the same line as the search input.

lukefretwell commented 10 years ago

Works for me. I'm noticing on the iPhone that the search box has a more curved radius than desktop view.

On Monday, March 3, 2014, Devin Price wrote:

Perhaps we should use negative margins to keep the so the submit button stays on the same line as the search input.

Reply to this email directly or view it on GitHubhttps://github.com/govfresh/govpress/issues/42 .

Luke Fretwell 415.722.8678 luke@lukefretwell.com http://lukefretwell.com

alaina13 commented 10 years ago

I fixed this by setting the search bar width to 70%. Not sure if this is the best solution, but it seems to be working for now...

input[type="search"] { padding: 3px; width: 70%; }

devinsays commented 10 years ago

These tiny bugs are the most difficult. I ended up rewriting all the form styles: 2a49cb4.

This should fix all the wrapping issues with the search button and field. I also think the field design looks much better.

We'll need to test this across all browsers:

devinsays commented 10 years ago

Button color now adopts the "link color" background. Will that look okay, or should we match it to something else? This can be tested by customizing the theme.

devinsays commented 10 years ago

Fixes for search on 404 page: ea4950e

lukefretwell commented 10 years ago

Looks fine to me: http://govpress.co/

devinsays commented 10 years ago

Limit search form width in footer widget: c19c49b